fix: cap VecOf pre-allocation to prevent OOM on malformed input#570
Merged
fix: cap VecOf pre-allocation to prevent OOM on malformed input#570
Conversation
Add a const generic MAX_LEN (default 65536) to VecOf that rejects decode attempts exceeding the limit. Also cap with_capacity to 1024 to avoid large pre-allocations from untrusted input. Existing VecOf<I, T> usages are unchanged due to the default value.
kvinwang
force-pushed
the
fix/vecof-unbounded-alloc
branch
from
e66ab0b to
ef774eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vec::with_capacityinVecOf::decodeto 1024 to prevent OOM when parsing malformed event logs with excessively large count valuespushif the actual count exceeds 1024Test plan
cargo check -p cc-eventlogpassesRef #567